Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analyzers] Resolve StyleCop issues: SA1516 and SA1616 #34853

Merged
merged 26 commits into from
Sep 16, 2024

Conversation

snickler
Copy link
Collaborator

Summary of the Pull Request

Resolved StyleCop issues SA1516 and SA1616 that have recently appeared in Visual Studio 17.12

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Member

@crutkas crutkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all whitespace, good to go

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @snickler , Thanks for opening the PR.
Why is this PR creating a AvancedPasteContext.cs file? e450163#diff-4cc7d732bfa287b2b2592df644079740a8c18868be1a6c57e0121a2d573ea6ac
Thought this was only whitespace fixes that were needed.

@snickler
Copy link
Collaborator Author

Hi @snickler , Thanks for opening the PR. Why is this PR creating a AvancedPasteContext.cs file? e450163#diff-4cc7d732bfa287b2b2592df644079740a8c18868be1a6c57e0121a2d573ea6ac Thought this was only whitespace fixes that were needed.

Ah thanks for finding that. I accidentally committed the fileI have for ANOTHER thing I'm working on ;). Let me fix that since it's not supposed to be checked in.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 37f2154 into main Sep 16, 2024
14 checks passed
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.85 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants